[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: glibc-2.4 fchownat bug [Re: 2 test failures
From: |
Jim Meyering |
Subject: |
Re: glibc-2.4 fchownat bug [Re: 2 test failures |
Date: |
Tue, 24 Oct 2006 08:47:10 +0200 |
Greg Schafer <address@hidden> wrote:
> But what about the slightly buggy "check-root" target? Any thoughts on that?
Sure. I fixed it like this:
2006-10-24 Jim Meyering <address@hidden>
Don't let a failure in one test stop "make -k" from running the others.
* tests/Makefile.am (t1 t2 t3 t4 t5): New targets.
(check-root): Depend on them, rather than executing the five
commands in a single rule. Reported by Greg Schafer.
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 376a2f0..b13294b 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -20,8 +20,7 @@ EXTRA_DIST = \
umask-check very-expensive
## N O T E :: Please do not add new tests/ directories.
-## Some people feel that there are too many already.
-## Put new tests in misc/.
+## There are too many already. Put new tests in misc/.
SUBDIRS = \
chgrp chmod chown cp cut dd dircolors du expr factor fmt head \
install join ln ls ls-2 md5sum misc mkdir mv od pr readlink rm rmdir \
@@ -29,12 +28,18 @@ SUBDIRS = \
tsort unexpand uniq wc
## N O T E :: Please do not add new directories.
-.PHONY: check-root
-check-root:
+.PHONY: check-root t1 t2 t3 t4 t5
+check-root: t1 t2 t3 t4 t5
+
+t1:
cd chown && $(MAKE) check TESTS=basic
+t2:
cd cp && $(MAKE) check TESTS=special-bits
+t3:
cd rm && $(MAKE) check TESTS=no-give-up
+t4:
cd rm && $(MAKE) check TESTS=fail-2eperm
+t5:
cd tail-2 && $(MAKE) check TESTS=append-only
check-recursive: root-hint