coreutils 6.5's ls crashes on unknown groups

[Adam Sampson]

Hiya,

Several of the changes to idcache.c between coreutils 6.4 and 6.5 are
broken -- they call strlen on a value that might be NULL. For example,
the group lookup code does this:

  grent = getgrgid (gid);
  name = grent ? grent->gr_name : NULL;
  tail = xmalloc (offsetof (struct userid, name) + strlen (name) + 1);

If the group being looked up doesn't exist, then that'll result in
strlen (NULL) being called. Hence:

$ /opt/packages/coreutils-6.4/bin/ls -ld work/elinks-0.11.2/config.h
-rw-r--r-- 1 20007 1001 20893 2006-11-19 13:47 work/elinks-0.11.2/config.h
$ /opt/packages/coreutils-6.5/bin/ls -ld work/elinks-0.11.2/config.h
Segmentation fault

This is on a Linux machine with glibc 2.3.6 -- but I wouldn't expect
strlen (NULL) to work on any machine. ;)

Thanks,

-- 
Adam Sampson <address@hidden>                         <http://offog.org/>