Re: coreutils 6.6 c89 build failures

[Matthew Woehlke]

Jim Meyering wrote:
> Matthew Woehlke <address@hidden> wrote:
> > Ok... would it be too much to ask for people making check-ins to first
> > check that building with '-Wdeclaration-after-statement' is clean?
> >
> > remove.c bombs (*badly*) on non-c99 compilers (in my case, Solaris 5.7,
> > but I know  that's not my only non-c99 platform); rm.c and shred.c also
> > fail (if less spectacularly). Patch attached.
>
> That is deliberate and documented.
> Perhaps you didn't read (or forgot about) this part of the README file?

Eheh, yup, sorry. :-) Plus the fact that coreutils and gnulib have 
different policies is confusing. Really, /why/ can we not just apply 
this patch and be done with it? Is it really so painful to support c89 
when the needed changes are so trivial and simply compiling with 
-Wdeclaration-after-statement would stop these things from creeping in?

Interesting how mine differs, though (heh, and I see a bug in mine now, 
too).

--
Matthew
"Two IIRC's must make a right" -- Larry Hall (paraphrased)