bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: lib/randread.c port to pedantic GCC (either C89 or C99)


From: Jim Meyering
Subject: Re: lib/randread.c port to pedantic GCC (either C89 or C99)
Date: Thu, 23 Nov 2006 01:10:03 +0100

Paul Eggert <address@hidden> wrote:
> When I wrote randread.c I forgot to put an #ifndef __attribute__ around
> the #define __attribute__, as all other files do.  Sorry about that.
>
> The bug crops up with pedantic GCC only.
>
> Here's a patch:
>
> 2006-11-22  Paul Eggert  <address@hidden>
>
>       * randread.c (__attribute__): Don't define if __attribute__ is
>       already defined.  Otherwise, the code won't conform to C99, since
>       the macro arg is spelled differently by some include file, and the
>       compilation fails with pedantic GCC.

Thanks.  Applied.
And pushed, so you can already see it here:

  http://git.sv.gnu.org/gitweb/?p=coreutils.git;a=summary

I've sync'd it to cvs, too, but it takes longer to reach that repository.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]