Re: coreutils-6.5: yet another C89 problem

[Jim Meyering]

Paul Eggert <address@hidden> wrote:
> Matthew Woehlke <address@hidden> writes:
>
>> Ok, happen to have a quick how-to? (A cron job that *doesn't* mail me
>> unless there is a problem would be nice :-).)
>
> http://buildbot.sourceforge.net/
>
> I haven't built one myself, but others have....

This will keep me from releasing decl-after-stmt code in coreutils/src:

        * Makefile.maint (patch-check): Compile patched sources with
        CFLAGS='-Wdeclaration-after-statement -Werror', to ensure that
        no violations remain.

diff --git a/Makefile.maint b/Makefile.maint
index 8fa6f70..9400b49 100644
--- a/Makefile.maint
+++ b/Makefile.maint
@@ -334,6 +334,9 @@ patch-check:
        if test "$${REGEN_PATCH+set}" = set; then \
          diff -upr src src-c89 > new-diff || : ; fi
        fail=0; test -s address@hidden && fail=1 || : ; \
+       rm -f src-c89/*.o || fail=1; \
+       $(MAKE) -C src-c89 CFLAGS='-g -Wdeclaration-after-statement -Werror' \
+         || fail=1; \
        rm -rf src-c89 address@hidden address@hidden; \
        test $$fail = 0