[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: coreutils-6.5: yet another C89 problem

From: Bob Proulx
Subject: Re: coreutils-6.5: yet another C89 problem
Date: Tue, 28 Nov 2006 01:22:43 -0700
User-agent: Mutt/1.5.9i

Jim Meyering wrote:
> Here's what Paul just added to Makefile.maint.
> That should do it, as long as you do that build
> on a relatively modern Linux system:
>     $ grep -C2 ansi Makefile.maint
>               && (cd src && patch -V never --fuzz=0 <c99-to-c89.diff) \
>               && ./configure --disable-largefile            \
>                   CFLAGS='-Werror -ansi -pedantic -Wno-long-long' \
>               && $(MAKE)
>             -rm -rf $(t)

Sure thing.  It is all set up with those options.

> Another one that'd be nice to automate (though not as important,
> so could be run far less frequently) is the "configure-without-NLS-
> then-compile-with-Wformat", from the preceding "my-distcheck" rules,
> in Makefile.maint:
>         && ./configure --disable-nls                  \
>         && $(MAKE) CFLAGS='-Werror -Wall -Wformat -Wshadow -Wpointer-arith' \
>             AM_MAKEFLAGS='$(null_AM_MAKEFLAGS)'       \

Okay.  I set that up to run nightly.

> Its purpose is to ensure that all format strings match the types of
> their arguments.  The only catch is that your tools/headers need to
> be at some minimum level.  I haven't tried running "make distcheck"
> on anything other than my bleeding-edge system.  You wouldn't need to
> bother with null_AM_MAKEFLAGS.
> Thanks for doing that!

No trouble at all.  Please feel free to ask for additional


reply via email to

[Prev in Thread] Current Thread [Next in Thread]