|
From: | Matthew Woehlke |
Subject: | Re: looking for ia64 linux newer than 2.4.19 [Re: coreutils-6.6 check failures on Itanium Linux |
Date: | Tue, 28 Nov 2006 14:36:10 -0600 |
User-agent: | Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.8) Gecko/20061025 Thunderbird/1.5.0.8 Mnenhy/0.7.4.0 |
Jim Meyering wrote:
I found a better way to handle this: * tests/mv/no-target-dir: Detect a buggy rename syscall. If found, skip this test. This happens at least on ia64 linux-2.4.19 w/ext3. Reported by Matthew Woehlke. Matthew or Bob, would you please confirm that this detects the problem and skips the test? [patch snipped]
Yes, that works (causes the test to be skipped). My only comment is I think I would like to see a more detailed message, maybe 'this test is being skipped because your kernel's rename() is buggy and does not permit a directory to be renamed onto an existing directory'.
And FYI dir2dir passes with your patch elsewhere in this thread. :-) Thanks! Making check in mv make[2]: Entering directory `/home/install/gnu/src/coreutils-6.6/tests/mv' make check-TESTS make[3]: Entering directory `/home/install/gnu/src/coreutils-6.6/tests/mv' PASS: hard-verbose PASS: backup-dir PASS: dir2dir mv: cannot move `a' to `b/a': Device or resource busy ./no-target-dir: skipping this test: your kernel's rename syscall is buggy SKIP: no-target-dir PASS: atomic ... PASS: trailing-slash ====================== All 34 tests passed (3 tests were not run) ====================== make[3]: Leaving directory `/home/install/gnu/src/coreutils-6.6/tests/mv' -- Matthew Caution: keep out of reach of adults.
[Prev in Thread] | Current Thread | [Next in Thread] |