bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Don't fail if acl test succeeds


From: Andreas Schwab
Subject: Don't fail if acl test succeeds
Date: Wed, 13 Dec 2006 13:39:08 +0100
User-agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.91 (gnu/linux)

The testsuite should not fail when the acl tests are working.  Use the
same logic as in the cp/acl test.

Andreas.

2006-12-13  Andreas Schwab  <address@hidden>

        * tests/mv/acl (skip): Check for acl support in the file system.

        * tests/mv/Makefile.am (XFAIL_TESTS): Remove.
        (TESTS_ENVIRONMENT): Pass CONFIG_HEADER.

diff --git a/tests/mv/Makefile.am b/tests/mv/Makefile.am
index 57581cd..0a1f2db 100644
--- a/tests/mv/Makefile.am
+++ b/tests/mv/Makefile.am
@@ -20,7 +20,6 @@
 
 AUTOMAKE_OPTIONS = 1.3 gnits
 
-XFAIL_TESTS = acl
 TESTS = \
   hard-verbose \
   backup-dir \
@@ -48,4 +47,5 @@ TESTS_ENVIRONMENT = \
   PERL="$(PERL)" \
   EGREP="$(EGREP)" \
   PATH="$(VG_PATH_PREFIX)`pwd`/../../src$(PATH_SEPARATOR)$$PATH" \
+  CONFIG_HEADER=$(CONFIG_HEADER) \
   PROG=mv
diff --git a/tests/mv/acl b/tests/mv/acl
index f570656..df3bb01 100755
--- a/tests/mv/acl
+++ b/tests/mv/acl
@@ -24,6 +24,13 @@
 # Make sure we get English translations.
 . $srcdir/../lang-default
 
+# Skip this test if cp was built without ACL support:
+grep '^#define USE_ACL 0' $CONFIG_HEADER > /dev/null && \
+  {
+    echo 1>&2 "$0: insufficient ACL support, so skipping this test"
+    (exit 77); exit 77
+  }
+
 if test "$VERBOSE" = yes; then
   set -x
   mv --version
@@ -46,15 +53,26 @@ framework_failure=0
 mkdir -p $tmp || framework_failure=1
 cd $tmp || framework_failure=1
 
+touch file || framework_failure=1
+
 if test $framework_failure = 1; then
   echo 'failure in testing framework'
   (exit 1); exit 1
 fi
 
+skip=no
+# Ensure that setfacl and getfacl work on this file system.
+setfacl -m user:bin:rw file 2> /dev/null || skip=yes
+acl1=`getfacl file` || skip=yes
+
+test $skip = yes &&
+  {
+    echo "$0: '.' is not on a suitable file system for this test" 1>&2
+    echo "$0: skipping this test" 1>&2
+    (exit 77); exit 77
+  }
+
 # move the access acl of a file
-touch file || framework_failure=1
-setfacl -m user:bin:rw file || framework_failure=1
-acl1=`getfacl file` || framework_failure=1
 mv file $other_partition_tmpdir || fail=1
 acl2=`cd $other_partition_tmpdir && getfacl file` || framework_failure=1
 test "$acl1" = "$acl2" || fail=1

-- 
Andreas Schwab, SuSE Labs, address@hidden
SuSE Linux Products GmbH, Maxfeldstra├če 5, 90409 N├╝rnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."




reply via email to

[Prev in Thread] Current Thread [Next in Thread]