Re: [PATCH] Command line parsing of ls with genparse

[Jim Meyering]

address@hidden (Michael Geng) wrote:
...
> of text. In the present version of ls the usage() function calls
> fputs() several times. The genparse version prints everything in
> 1 single call to printf(). So the usage() text in the present ls.c
> is split into multiple _() macros, whereas ls-clp.c uses 1 single _()
> macro for the whole help screen.

Consider separating it into strings no longer than 509 bytes each
and printing them separately.  That's a portability limitation imposed
by some c89 compilers.  (see gcc's -Woverlength-strings)

If you were to run "make distcheck", this and some other problems
would be exposed.  For example, you added at least one function
that was not declared static.

With your changes does "make check" still pass?