bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: GNU_PACKAGE vs. PACKAGE_NAME


From: Jim Meyering
Subject: Re: GNU_PACKAGE vs. PACKAGE_NAME
Date: Thu, 30 Aug 2007 17:18:55 +0200

Eric Blake-1 <address@hidden> wrote:
...
> Subject: [PATCH]      Use PACKAGE_NAME instead of GNU_PACKAGE.
>       * src/Makefile.am (.sh, uninstall-local): Adjust all users of
>       hand-rolled GNU_PACKAGE to instead use autoconf-provided
>       PACKAGE_NAME.
>       * src/basename.c (main): Likewise.

Reviewed it right away, after all.
Looks fine.  Only nit: in the future, please keep global-subst changes
separated from unrelated ones like this:

        * configure.ac (AC_CHECK_DECLS): No need to check strtoimax,
        strtoumax, since gnulib does this.

Unrelated changes like that would usually go in a separate delta.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]