[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: finger & pinky commands reports improper exit status

From: Jim Meyering
Subject: Re: finger & pinky commands reports improper exit status
Date: Fri, 04 Jul 2008 08:43:20 +0200

"Halesh S" <address@hidden> wrote:
> The last patch has missied for no-args.
> The attached patch will fix the issue.

Thanks for the work and patches.
However, before I can accept it, here are some things you'll need to do:

  - also work with -l (long_pinky)
  - "pinky" (with no arguments) should not fail when there are no entries.
  - use error (EXIT_FAILURE, 0,... , not fprintf (stderr...+exit 1.
  - don't use negation in a variable name: use "bool match = false;", not...
  - use indentation that's consistent with surrounding code

Also, please read the guidelines in the relatively new file, HACKING.
(get a copy via "git clone git://git.sv.gnu.org/coreutils") In
particular, you'll have to write a ChangeLog entry that will serve as
commit log message and to run "git format-patch" to produce the patch
you eventually send.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]