[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: finger & pinky commands reports improper exit status

From: Jim Meyering
Subject: Re: finger & pinky commands reports improper exit status
Date: Fri, 04 Jul 2008 10:19:31 +0200

"Halesh S" <address@hidden> wrote:

> On 7/4/08, Jim Meyering <address@hidden> wrote:
>> "Halesh S" <address@hidden> wrote:
>>> The last patch has missied for no-args.
>>> The attached patch will fix the issue.
>> Thanks for the work and patches.
>> However, before I can accept it, here are some things you'll need to do:
>>   - also work with -l (long_pinky)
>      Done and tested.

Not tested?  Doesn't work properly.

>>   - "pinky" (with no arguments) should not fail when there are no entries.
>       Done and tested.

Not tested?  Still fails.

>>   - use error (EXIT_FAILURE, 0,... , not fprintf (stderr...+exit 1.
>       Done.
>>   - don't use negation in a variable name: use "bool match = false;", not...
>      Done.

Not done.
There's still a variable name starting with "not_".
Use "match", as I suggested.

>>   - use indentation that's consistent with surrounding code
>     Followed.

Indentation is still irregular (spaces vs TABs).
Also, please don't add trailing blanks.
They cause "make syntax-check" to fail.

>> Also, please read the guidelines in the relatively new file, HACKING.
>> (get a copy via "git clone git://git.sv.gnu.org/coreutils") In
>> particular, you'll have to write a ChangeLog entry that will serve as
>> commit log message and to run "git format-patch" to produce the patch
>> you eventually send.
> I am not able to it..
> I have attached a patch. If possible you do the git.

Install git, run the "git clone..." command above, and follow the
instructions in HACKING.

pinky is a program that few people use, and the behavior you're
changing isn't even really a bug.
If you can submit a perfect patch that I can apply with next
to no effort, then the small improvement is worthwhile.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]