[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: sort of new branch: next

From: Pádraig Brady
Subject: Re: sort of new branch: next
Date: Wed, 31 Dec 2008 01:06:38 +0000
User-agent: Thunderbird (X11/20071008)

Jim Meyering wrote:
> I've pushed a few changes to a new "next" branch.
> I expect to rebase it against master.
>   $ g shortlog HEAD ^master
>         build: use dist-xz, not dist-lzma
>         cleanup/modernize: don't test HAVE_MBRTOWC; now gnulib provides it
>         portability: accommodate gnulib's getaddrinfo change
>         maint: move coreutils-specific syntax check rules into cfg.mk
>         maint: tighten m4 AC_ quoting check
>         maint: use more sc_-prefixed names
>         maint: factor out common code; prohibit use of HAVE_MBRTOWC

The above look sensible from a _very_ quick review

>         bootstrap: don't use cmp's -s option when reading from a pipe

I see cmp used all over the place (provided by diffutils on my fedora box).
Should I be adding cmp to the requirements in bootstrap.conf?

I also noted that you can restrict the following function
to just coreutils apps as follows?

insert_sorted_if_absent() {
  test -f $file || touch $file
  test "$((echo "$str"; uniq $file) | LC_ALL=C sort | uniq -d)" ||
  echo "$str" | sort -u - $file -o $file ||
  exit 1


reply via email to

[Prev in Thread] Current Thread [Next in Thread]