[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] cp/mv: xattr support

From: Pádraig Brady
Subject: Re: [PATCH] cp/mv: xattr support
Date: Fri, 23 Jan 2009 12:26:58 +0000
User-agent: Thunderbird (X11/20071008)

Kamil Dudka wrote:
>>>>> +# Skip this test if cp was built without xattr support:
>>>>> +grep '^#define USE_XATTR 1' $CONFIG_HEADER > /dev/null ||
>>>>> +  skip_test_ "coreutils built without xattr support"
>>>> I'd rather test a binary as it's little less coupled I think:
>>>> cp --preserve=xattr --help >/dev/null 2>&1 ||
>>>>   skip_test_ "coreutils built without xattr support"
> Slightly changed to use cp -n instead of cp --help as --help always returns 

Ah because you don't check for !USE_XATTR during option processing,
instead deferring to later. I suppose that's OK.

So patch looks good!


reply via email to

[Prev in Thread] Current Thread [Next in Thread]