[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] factor.c (NDEBUG): Define this before including <assert.h>,
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH] factor.c (NDEBUG): Define this before including <assert.h>, not after. |
|
Date: |
Tue, 10 Mar 2009 14:43:16 +0000 (UTC) |
> coreutils/src/factor.c #defines NDEBUG after including <assert.h>.
> It's
> supposed to be defined before.
Why is factor.c even messing with NDEBUG? The point of the gnulib assert
module is to allow ./configure-time control over whether assertions
are enabled, and this patch would mean that for this file, the user
no longer has control over that option.
--
Eric Blake