bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: coreutils 7.1.49-ebb9 FTB risc/HP-UX


From: Eric Blake
Subject: Re: coreutils 7.1.49-ebb9 FTB risc/HP-UX
Date: Fri, 20 Mar 2009 06:24:52 -0600
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.21) Gecko/20090302 Thunderbird/2.0.0.21 Mnenhy/0.7.6.666

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Jim Meyering on 3/20/2009 12:34 AM:
> I like it.  Thanks.
> However, I'd like to keep O_FULLBLOCK as a single-bit value.
> That's slightly less surprising, and makes the change a tad
> smaller.  How about this?

Fair enough; I debated about doing it myself.  Plus, it makes it easier to
add future extensions, should the need arise:

v1 = v & ~O_FULLBLOCK,
O_NEW_FLAG = v1 ^ (v1 & (v1 - 1)),
v2 = v1 & ~O_NEW_FLAG,...

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAknDixQACgkQ84KuGfSFAYCOWgCglTdV43KimQ4lC7bmavFlPO+n
bhQAoJnPuhnmQ5u7D+tCvLSlln5v1Mdz
=2ucr
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]