Re: [PATCH]: remove one duplicity in copy.c caused by factorization

[Jim Meyering]

Ondřej Vašík wrote:
> while making coreutils update for F-11, I spotted one duplicity in
> copy.c caused by
> http://git.savannah.gnu.org/cgit/coreutils.git/commit/?id=e0cf592f48b4e67dc31d0482ae4f4dbc820e883e
>  factorization commit. Attached patch removes this duplicity.
>
>
> Greetings,
>          Ondřej Vašík
>
>
> From 430ea6c024fdef7598d676438cc37b341912be75 Mon Sep 17 00:00:00 2001
> From: =?utf-8?q?Ond=C5=99ej=20Va=C5=A1=C3=ADk?= <address@hidden>
> Date: Wed, 8 Jul 2009 17:00:47 +0200
> Subject: [PATCH] copy.c: remove duplicity caused by factorization
>
> * copy.c (copy_attr_error): remove duplicity caused by factorization
> ---
>  src/copy.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/src/copy.c b/src/copy.c
> index 511f705..4c8c432 100644
> --- a/src/copy.c
> +++ b/src/copy.c
> @@ -146,7 +146,6 @@ copy_attr_error (struct error_context *ctx 
> ATTRIBUTE_UNUSED,
>    va_list ap;
>
>    if (!errno_unsupported (errno))
> -  if (errno != ENOTSUP && errno != ENODATA)
>      {

Wow.  That's ugly.
I'm glad you caught it.  Thanks!

Good argument for enforcing indentation rules.