[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: avoiding 'dead store's reported by clang
From: |
Pádraig Brady |
Subject: |
Re: avoiding 'dead store's reported by clang |
Date: |
Tue, 1 Sep 2009 11:18:08 +0100 |
User-agent: |
Thunderbird 2.0.0.6 (X11/20071008) |
Jim Meyering wrote:
> I've run clang on coreutils, and it spotted quite a few dead stores.
> These changes remove them:
>
> The chmod.c change below was not completely transparent, since
> the new code returns immediately after issuing the root-dev-inode
> warning, whereas the old code would fall through, and thus might
> have also printed --verbose diagnostics.
>
> Other than that, these are supposed to be "no semantic change" patches.
These look good.