|
From: | Jim Meyering |
Subject: | Re: [PATCH] chcon, chmod, chgrp, chown, du: do not ignore fts_close failure |
Date: | Tue, 01 Sep 2009 12:32:09 +0200 |
Pádraig Brady wrote: > Jim Meyering wrote: >> The following patch will be required when coreutils >> next updates from gnulib, with gnulib's just-added warn_unused_result >> attribute on fts_close. >> >> It eliminates a slight risk that fts_close would fail and these >> applications would ignore that failure and exit successfully. > > Do we want to fail silently though (however unlikely)? > I.E. do these need: error (0, errno, _("fts_close failed")); Good catch! Thanks! I actually thought about that, but was too hasty and didn't do it. Addendum coming up.
[Prev in Thread] | Current Thread | [Next in Thread] |