[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
compiler warning cleanup
From: |
Eric Blake |
Subject: |
compiler warning cleanup |
Date: |
Mon, 21 Sep 2009 16:29:36 +0000 (UTC) |
User-agent: |
Loom/3.14 (http://gmane.org/) |
This patch cleans up compiler warnings on cygwin 1.5. In particular, warning
cleanup by code deletion is kind of fun.
From: Eric Blake <address@hidden>
Date: Mon, 21 Sep 2009 10:28:01 -0600
Subject: [PATCH] build: avoid compiler warnings on cygwin 1.5
* src/copy.c (utimens_symlink): Avoid unused variables.
* src/su.c (getusershell): Rely on gnulib for prototype.
---
src/copy.c | 3 +++
src/su.c | 10 ----------
2 files changed, 3 insertions(+), 10 deletions(-)
diff --git a/src/copy.c b/src/copy.c
index b7d113f..067b1e7 100644
--- a/src/copy.c
+++ b/src/copy.c
@@ -132,6 +132,9 @@ utimens_symlink (char const *file, struct timespec const
*timespec)
utimensat fails with ENOSYS. Ignore that. */
if (err && errno == ENOSYS)
err = 0;
+#else
+ (void) file;
+ (void) timespec;
#endif
return err;
diff --git a/src/su.c b/src/su.c
index ec50a3b..25b8838 100644
--- a/src/su.c
+++ b/src/su.c
@@ -53,16 +53,9 @@
#include <pwd.h>
#include <grp.h>
-/* Hide any system prototype for getusershell.
- This is necessary because some Cray systems have a conflicting
- prototype (returning `int') in <unistd.h>. */
-#define getusershell _getusershell_sys_proto_
-
#include "system.h"
#include "getpass.h"
-#undef getusershell
-
#if HAVE_SYSLOG_H && HAVE_SYSLOG
# include <syslog.h>
#else
@@ -119,9 +112,6 @@
#define DEFAULT_USER "root"
char *crypt (char const *key, char const *salt);
-char *getusershell (void);
-void endusershell (void);
-void setusershell (void);
extern char **environ;
--
1.6.1.2
- compiler warning cleanup,
Eric Blake <=