[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] ls: support disabling colors on all subtypes
From: |
Jim Meyering |
Subject: |
Re: [PATCH] ls: support disabling colors on all subtypes |
Date: |
Tue, 22 Sep 2009 12:37:20 +0200 |
Pádraig Brady wrote:
> Jim Meyering wrote:
>> Pádraig Brady wrote:
>>> Subject: [PATCH] ls: allow disabling colors on all file types
>>>
>> Thanks for doing this.
>> However, with that change, the ls/no-cap test now fails:
>> (on Fedora 11, configured with libcap-devel.x86_64)
>>
>> make check -C tests TESTS=ls/no-cap VERBOSE=yes
>
> Oops, that test was skipped on my system. I needed:
> sudo yum install libcap-devel
> I must look at warning or at least documenting
> these optional libs to get full coverage.
>
> I switched the other tests to call is_colored() last
> as that's probably faster for all other cases, and
> I switched this one for consistency. But as noted in
> http://git.savannah.gnu.org/gitweb/?p=coreutils.git;a=commit;h=f3f1ccfd
> that order was on purpose for performance reasons.
>
> I'll push the attached.
Thanks for the quick fix.