Re: modify chmod

[Jim Meyering]

jeff.liu wrote:
> A tiny patch, make chmod do not touch the inode if the new file
> permission mode is same as it was before.
...
> +static bool
> +may_have_nfsacl(const char *file)
> +{
> +# if HAVE_SYS_VFS_H && HAVE_SYS_STATFS_H && HAVE_STRUCT_STATFS_F_TYPE
> + struct statfs buf;
> +
> + /* If statfs fails, assume we can't use the optimization. */
> + if (statfs (file, &buf) < 0)

This function should accept a file descriptor, not a file name,
and should call fstatfs, not statfs.

For your next version of this patch, please find a way to send
it that does not split lines or remove leading spaces.