bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Final point in new option of join


From: Pádraig Brady
Subject: Re: Final point in new option of join
Date: Tue, 16 Feb 2010 00:09:51 +0000
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.7) Gecko/20100111 Thunderbird/3.0.1

On 12/02/10 18:14, Jim Meyering wrote:
Pádraig Brady wrote:
I've added a syntax-check rule to grep the man pages
for --options with descriptions with initial uppercase letters
in the attached.

Thanks!

Subject: [PATCH] doc: fix inconsistent capitalization in --help output
...

Looks fine.  One minor nit.
Rules that run a sub-make should be listed in ALL_RECURSIVE_TARGETS:

diff --git a/cfg.mk b/cfg.mk
index b5a21c3..dd6da25 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -171,6 +171,14 @@ ALL_RECURSIVE_TARGETS += sc_check-AUTHORS
  sc_check-AUTHORS:
        @$(MAKE) -C src $@

+# Option descriptions should not start with a capital letter
+# One could grep source directly as follows:
+# grep -E " {2,6}-.*[^.]  [A-Z][a-z]" $$($(VC_LIST_EXCEPT) | grep '\.c$$')
+# but that would miss descriptions not on the same line as the -option.

ALL_RECURSIVE_TARGETS += sc_option_desc_uppercase

You don't miss much :)
I noticed that right after sending.

+sc_option_desc_uppercase:
+       @$(MAKE) -C src $@
+       @$(MAKE) -C man $@

I've pushed with the above changed to:

@$(MAKE) -s -C src all_programs
@$(MAKE) -s -C man $@

The -s is defined by POSIX and is available
on linux/BSD/solaris at least, and makes
the output from `make syntax-check` much cleaner.
I might add it to all syntax-check sub makes.

cheers,
Pádraig.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]