Re: bug #26512 (C_NORM unused)

[Pádraig Brady]

On 15/02/10 20:05, Moritz Orbach wrote:
> Hello all,
>
> attached is a patch for bug #26512
> http://savannah.gnu.org/bugs/index.php?26512
>
> Is it correct? make distcheck still passes all tests. There's a
> seemingly useless C_RESET at every end of line, just before the next
> color sequence at the start of the next line -- but that's the same
> behaviour as "ls -x" before the patch, so maybe it is needed?
>
> Could you please incorporate this into the next release?
>
> The change in behaviour was introduced with the following commit. C_NORM was
> unused since then.
>
> commit 483297d5ddaea930d61da1da9c3f052cbd3c3810
> Author: Ed Avis<address@hidden>
> Date:   Tue Feb 12 12:22:35 2008 +0100

You're right, the following should show bold/bright text:

LS_COLORS=no=1 ls -l --color

Also, "no" being configurable is alluded to in:
dircolors -p | grep NORMAL

The patch looks sensible at first glance.
I'll test it thoroughly tomorrow morning and check it in.

thanks!
Pádraig.