[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#10021: [PATCH id] Add error-checking on GNU

From: Paul Eggert
Subject: bug#10021: [PATCH id] Add error-checking on GNU
Date: Sat, 12 Nov 2011 15:15:34 -0800
User-agent: Mozilla/5.0 (X11; Linux i686; rv:7.0.1) Gecko/20110929 Thunderbird/7.0.1

On 11/12/11 13:48, Ludovic Courtès wrote:
> +#ifdef __GNU__
> +      if (euid == -1 && !use_real
> +          && !just_group && !just_group_list && !just_context)
> +        error (EXIT_FAILURE, errno, _("cannot get effective UID"));
> +#endif

I suggest removing the "#ifdef __GNU__" here and in its other
three uses in the patch, as functions like as geteuid() can fail on
a few non-GNU systems too.  See:


For this particular application (the 'id' program) I doubt whether
it's worth our time to configure this stuff at compile-time,
and that it's fine to do a run-time check on all platforms.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]