[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#10021: [PATCH id] Add error-checking on GNU

From: Jim Meyering
Subject: bug#10021: [PATCH id] Add error-checking on GNU
Date: Mon, 14 Nov 2011 08:22:28 +0100

Ludovic Courtès wrote:
> Jim Meyering <address@hidden> skribis:
>> Oh, I also had to make the new test script executable,
>> or else "make check" would fail.
> It works for me even if it’s not executable when I run “make check
> TESTS=id/gnu-zero-uids”, apparently because it’s run this way:
>   execve("/bin/sh", ["/bin/sh", "./shell-or-perl", "--test-name",
> "id/gnu-zero-uids", "--srcdir", ".", "--shell", "/bin/sh", "--perl",
> "perl", "--", "./id/gnu-zero-uids"], [/* 96 vars */]) = 0

The test itself runs either way.  However there's a make check
sub-test (vc_exe_in_TESTS) that ensures all such scripts are
consistently chmod a+x.  It was failing.

> It might be different when running just “make check”.
> (I tested it on GNU/Linux and GNU/Hurd.)
>> Since I've made so many changes, I'll wait to hear back
>> from you before pushing it.
> Looks good to me, thank you!
>> +  test "$(uname)" = GNU \
> So you’re assuming Bash, right?

No.  The test starts with the usual invocation of init.sh,
which ensures we're using a shell that handles $(...).

reply via email to

[Prev in Thread] Current Thread [Next in Thread]