|
From: | Pádraig Brady |
Subject: | bug#13391: dd silently ignores lseek error |
Date: | Thu, 17 Jan 2013 11:56:44 +0000 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 |
On 01/09/2013 10:08 AM, Pádraig Brady wrote:
On 01/09/2013 07:36 AM, Bernhard Voelker wrote:why not check input_seekable where it is set - ~60 lines above?I was trying to keep related code together. Thanks for all the reviews, which I've fixed locally. To provide an argument for why this shouldn't go in, the following is equivalent: python -c 'import os; os.lseek(0,0,os.SEEK_CUR)' 2>/dev/null < /the/file && dd if=/the/file ... So if the need is esoteric enough the above might suffice? I'll leave it stew for a while longer.
I'm still 50:50 give the above, so I'll not push until I get more positive feedback. The latest is attached for reference. thanks, Pádraig.
dd-seekable.diff
Description: Text Data
[Prev in Thread] | Current Thread | [Next in Thread] |