[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#23153: [PATCH]: For FIXME in cp.c
From: |
Rishabh Dave |
Subject: |
bug#23153: [PATCH]: For FIXME in cp.c |
Date: |
Tue, 5 Apr 2016 20:19:24 +0530 |
Did fix that - changing function call to GNU style and "suffix_from_env" to
local variable. The corresponding patch is attached.
On Mon, Apr 4, 2016 at 10:36 PM, Paul Eggert <address@hidden> wrote:
> On 04/04/2016 09:30 AM, Rishabh Dave wrote:
>
>> + char *suffix_from_env;
>> size_t ssize;
>> bool simple = true;
>> +
>> + /* If simple_backup_suffix is '~', check environment if we have any
>> there. */
>> + if (strcmp(simple_backup_suffix, "~") == 0)
>> + if ((suffix_from_env = getenv("SIMPLE_BACKUP_SUFFIX")) != NULL)
>> + simple_backup_suffix = xstrdup (suffix_from_env);
>> +
>>
>
> The usual GNU style is "f (x)" rather than "f(x)" for function calls.
> Also, avoid side effects in an "if"; just have the then-part with a local
> variable "suffix_from_env" and put the subsidary if after that.
>
FIXME-regarding-getenv.patch
Description: Text Data