bug#39364: [PATCH] rmdir: fix clobbered errno

[Pádraig Brady]

On 03/02/2020 16:45, Pádraig Brady wrote:
> On 03/02/2020 13:26, Pádraig Brady wrote:
> > On 31/01/2020 17:51, Pádraig Brady wrote:
> > Actually I think the key issue is not errno handling,
> > but a logic error fixed with:
> >
> > @@ -102,7 +102,7 @@ ignorable_failure (int error_number, char const *dir)
> >       return (ignore_fail_on_non_empty
> >               && (errno_rmdir_non_empty (error_number)
> >                   || (errno_may_be_empty (error_number)
> > -                  && is_empty_dir (AT_FDCWD, dir))));
> > +                  && ! is_empty_dir (AT_FDCWD, dir))));
> >
> >
> > Attached is a full patch to address these issues.
>
> I'll also squash this in to the previous commit,
> to ensure we diagnose the case where we can't
> determine if the directory is empty.

pushed. marking done