Re: [Bug-cpio] cpio-2.9.90 (alpha) available.

[Sergey Poznyakoff]

Hi Ladislav,

> I  check the code against patches which we in openSUSE distribution.
> I think you forgot to change the type of some variables. You use type
> "off_t" elsewhere for variables which represents number of bytes/ file
> size.
> Attaching patch as cpio-2.9-variable_type.patch.

Thanks for reminding me. I have applied it.
 
> There are also some patches which you can consider to apply.
> For example cpio-2.9-use_new_ascii_format.patch is widely used in
> distros like Mandriva, Red Hat and openSUSE.

I have strong doubts about that one. First of all, patching .info file
is entirely senseless. Secondly, the `-c' switch was used for years for
old ASCII format and changing it brusquely will hurt backward
compatibility. Thirdly, the proposed code

#define        SVR4_COMPAT
#ifdef SVR4_COMPAT
        archive_format = arf_newascii; /* -H newc.  */
#else

is an example of a pretty dirty way of writing.

Returning to the matter, is there any practical reason for changing the
meaning of `-c', apart from the fact that some distros use it?
         
> cpio-2.9-doc_typo.patch: This patch appeared in this mailing list some
> time ago.

Thanks again, I have applied this one.

> cpio-2.9-avoid_overflow_warning.patch: Gcc complaints about overflow.
> I don't know why this hack in the code was used, but IMHO it can be
> done in way which is more clear what is written where.

Yes, sure. I have applied this one as well.

> Last but not least:
> cpio-2.9-chmodRaceC.patch:  This one comes from Red Hat and fixes
> security issue connected to CAN-2005-1111 in cpio version 2.9.

I will consider this.

Regards,
Sergey