Re: [Bug-cpio] out-of-bounds write with cpio -i

[Pavel Raiskup]

On Monday 01 of December 2014 21:15:59 Sergey Poznyakoff wrote:
> Hi Florian,
> 
> > off_t is signed, so you need to check for out-of-bounds values before
> > adding 1 (because signed overflow is undefined), and you also have to
> > guard against negative values.
> 
> Good point, thanks for noticing.  I fixed this.

Thanks for fixing!  Just a nit:

-      link_name = xmalloc (file_hdr->c_filesize);
+      link_name = xmalloc (file_hdr->c_filesize + 1);

Also, the testsuite needs to be adjusted probably.

Pavel

testsuite.log.xz
Description: application/xz