Re: [PATCH resend] Wrong CRC with ASCII CRC for large files

[Stefano Babic]

Hi Sergey,

On 10.04.23 02:25, Dominique Martinet wrote:
> Sergey Poznyakoff wrote on Fri, Apr 07, 2023 at 10:32:06AM +0200:
> > Thanks for reporting that. I'm ashamed to have overlooked this issue.
>
> It happens, I was just annoyed at the snark remark in the yocto
> commit despite no visible attempt to send the patch again :)
>
> > The original patch, while fixing the bug, inadvertently introduced
> > another one: eventual read error was never caught
>
> Indeed, if bytes_read become unsigned then it can never be negative.
> Good catch & sorry for not checking before resending.
>
> > so I installed this patch instead:
> >
> >   
> > http://git.savannah.gnu.org/cgit/cpio.git/commit/?id=a1b2f7871c3ae5113e0102b870b15ea06a8f0e3d
>
> This looks good to me, thank you!

Indeed, thanks for taking care and fixing !

Is it planned to have a release for this ? It will surely take a while 
until distros will update to this. Will be a 2.13-21 ?

Best regards,
Stefano

--
=====================================================================
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich,   Office: Kirchenstr.5, 82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================