[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-cssc] Test delta/errorcase.sh -> E30 .. E32

From: James Youngman
Subject: Re: [Bug-cssc] Test delta/errorcase.sh -> E30 .. E32
Date: Sun, 22 May 2011 15:47:26 +0100

On Sun, May 22, 2011 at 2:56 PM, James Youngman <address@hidden> wrote:
> On Sun, May 22, 2011 at 2:22 PM, Joerg Schilling

>> Then I don't understand the purpose of you test as it seems to verify that
>> there is no such automatic switch to binary mode.
> That is not what the test verifies, as I have repeatedly tried to
> explain, and as the code clearly shows.   I don't know how to explain
> this more clearly.   Perhaps if you take a look at the code again:
> then
>    ## Real SCCS fails on these inputs:-
>    test_bin   fb10 "foo"               # no newline at end of file.
>    test_ascii fa11 "x\000y\n"          # ASCII NUL.
> else
>    echo "Some tests skipped (since SCCS fails them but CSSC should pass)"
> fi

Perhaps that was an unnecessarily terse response.   The point is that
all of these are success case tests, but the fa11 test verifies that
NUL is accepted in a file body, since as far as I understand things
it's BOL followed by \001 which causes versions of SCCS which support
binary files to activate that support.

Since the system diff will often not cope with this, it's actually not
verifying an invariant that's genuinely useful in many cases.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]