[Bug-cssc] [bug #43360] #error "Please include config.h first."

[Ryan Schmidt]

URL:
  <http://savannah.gnu.org/bugs/?43360>

                 Summary: #error "Please include config.h first."
                 Project: GNU CSSC
            Submitted by: ryandesign
            Submitted on: Sun 05 Oct 2014 08:15:35 AM GMT
                Category: None
                Severity: 3 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

CSSC 1.4.0 builds on OS X 10.7 and later, but fails on OS X 10.6 (and possibly
earlier) due to the same problem reported on the bug mailing list:


../gl/lib/unistd.h:135:3: error: #error "Please include config.h first."


http://lists.gnu.org/archive/html/bug-cssc/2014-09/msg00003.html

and supposedly fixed with this commit:

http://git.savannah.gnu.org/cgit/cssc.git/commit/?id=9737f41b5d2a49e61061e9f896b5a9ae19e3a3ac

I backported that to 1.4.0 and it now failed to build with a very similar
error message with a different source file, version.cc. version.cc doesn't
directly include unistd.h, but does include stdio.h; perhaps on this version
of OS X stdio.h eventually includes unistd.h. In any case making a similar
change to version.cc.in allowed the build to succeed:

https://trac.macports.org/browser/trunk/dports/devel/cssc/files/patch-src-version.cc.in.diff?rev=126199


Side note: I'm unclear why you're sometimes writing:


#include <config.h>


Since it's a file local to your source directory, shouldn't it always be:


#include "config.h"






    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?43360>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/