[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Bug-ddrescue] Re: ddrescue patch for unsigned/signed compiler warnings
From: |
Antonio Diaz Diaz |
Subject: |
[Bug-ddrescue] Re: ddrescue patch for unsigned/signed compiler warnings |
Date: |
Sat, 27 Feb 2010 17:28:41 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i586; en-US; rv:1.7.11) Gecko/20050905 |
Hello Martin,
Martin Koeppe wrote:
> Unfortunately gddrescue is not available for Windows.
There is at least a cygwin port of ddrescue. Just search for "ddrescue
cygwin".
> One case isn't quite obvious to me, however:
> Why is in block.h, class Block, element size_ defined as long long?
Because it needs to be at least 64 bits long.
> In ddrescue.cc readblock() is called several times with such a long long
> sized block as parameter.
If your compiler barks at this, I can easily solve it with a cast. The
real value never exceeds what readblock can accept.
> here comes my patch against 1.11 so that MSVC is happy and doesn't
issue signed/unsigned warnings anymore.
I think there are no real signed/unsigned issues in ddrescue; no value
ever exceeds the maximum positive signed value. I'll try to fix all the
signed/unsigned warnings you get, but I can't apply your patch because
it breaks build in GNU systems.
Regards,
Antonio.
- [Bug-ddrescue] Re: ddrescue patch for unsigned/signed compiler warnings,
Antonio Diaz Diaz <=