[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-dejagnu] Minor issues after merging patch "Eureka! The testsuit
Re: [Bug-dejagnu] Minor issues after merging patch "Eureka! The testsuite can now test individual tools."
Mon, 5 Nov 2018 16:10:57 +1100
On Thu, Nov 01, 2018 at 12:03:50AM -0500, Jacob Bachmeyer wrote:
> First, Makefile.in needs to be regenerated as automake parameters
> have changed. The configure script is fine; the earlier patch to
> configure.ac added only comments.
I fixed that, thanks.
> Second, it seems that my approach of including ChangeLog entries in
> the patch has resulted in a duplicated ChangeLog entry for this
> patch. Is this to be considered an unavoidable error or is there
> some change in procedures that should be made to prevent this from
> recurring? (In other words, what, if anything, should I do
> differently in the future? There are more patches planned.)
Generally, just paste the ChangeLog text directly into the email with
the patch following below. Don't send diffs to the ChangeLog. They
apply so rarely. I also tend to update the date stamp on the ChangeLog
entry one day ahead to the date in the submittted patch due to my
position relative to the international date line. :-)