[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#41587: Configuring DejaGnu using a relative path causes the testsuit

From: Jacob Bachmeyer
Subject: bug#41587: Configuring DejaGnu using a relative path causes the testsuite to fail
Date: Thu, 28 May 2020 22:06:04 -0500
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20090807 MultiZilla/ SeaMonkey/1.1.17 Mnenhy/

Rob Savoye wrote:
On 5/28/20 7:25 PM, Jacob Bachmeyer wrote:
In current Git master, some parts of the DejaGnu testsuite fail if
DejaGnu was configured using a relative srcdir, as by
"../src/dejagnu/configure".  This was uncovered while investigating the
issue that became bug#41585.

  Interesting, relative paths to configure are working fine for me.

Very interesting; they cause options.exp and the launcher tests to fail here. In any case, commit 6a5b5861457230cc9ff5e01dc2ad3e1435051b93 should make the code more readable in the future and the other patches submitted on temporary branch PR41587 should make the testsuite more robust in general.

The change in runtest.exp was the beginning of a different development direction: making "testsuite file" sensitive to changing directories if the original directories had relative names. That path might be good as a future feature improvement, but it would not have fixed the observed problem here, so it was quickly abandoned. I saw that were two procedure definitions between setting and reporting $logname, so I moved those closer together. I was looking for a place to add storing and reporting the initial working directory, but later realized that the init file could legitimately change it along with setting different srcdir/objdir/etc. values.

On a side note, you can close a bug on debbugs by sending mail to <bugnumber>-done@debbugs.gnu.org. The "closing note" also goes out as part of the bug records. I will take care of closing these two bugs and deleting the temporary branches if you want.

-- Jacob

reply via email to

[Prev in Thread] Current Thread [Next in Thread]