[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#48155: [dejagnu-1.6.3-rc4] make check depends on SHELL

From: Jacob Bachmeyer
Subject: bug#48155: [dejagnu-1.6.3-rc4] make check depends on SHELL
Date: Tue, 04 May 2021 23:13:36 -0500
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20090807 MultiZilla/ SeaMonkey/1.1.17 Mnenhy/

Kiyoshi KANAZAWA wrote:
From: Jacob Bachmeyer <jcb62281@gmail.com>
With CONFIG_SHELL=/bin/sh, does the testsuite complete successfully?

Yes, "make -k check" returns 0 with saying as follows.

This patch (from commit da5984550f2d78388bc934016b0c3461ddc8b0a4) should fix the problem, or at least ensure that an error is produced immediately if config.guess does not work. It will be included in release candidate 5.

diff --git a/runtest.exp b/runtest.exp
index d950171..0e077ae 100644
--- a/runtest.exp
+++ b/runtest.exp
@@ -862,7 +862,7 @@ if {[expr {$build_triplet eq "" && $host_triplet eq ""}]} {
-    if { ![regexp -- {^[^-]+-[^-]+-[^-]+} $build_triplet] } {
+    if { ![regexp -- {^[[:alnum:]_.]+(-[[:alnum:]_.]+)+$} $build_triplet] } {
       send_error "ERROR: Running config.guess produced bogus build triplet:\n"
       send_error "        $build_triplet\n"
       send_error "       (Perhaps you need to set CONFIG_SHELL or\

Ignoring an unusable $SHELL remains a possible future addition.

-- Jacob

reply via email to

[Prev in Thread] Current Thread [Next in Thread]