[bug-diffutils] bug#24137: bug#24137: [platform-testers] new snapshot available: diffutils-3.3.57-a37c

[Jim Meyering]

On Wed, Aug 3, 2016 at 12:52 AM, Dagobert Michelsen <address@hidden> wrote:
> Hi Jim,

Thanks for more quick testing.

>> Am 03.08.2016 um 05:00 schrieb Jim Meyering <address@hidden>:
>>
>> Here's another snapshot.
...
> Now I get on Solaris 10 x86:
>
>> gmake  check-TESTS
>> gmake[1]: Entering directory 
>> '/home/dam/mgar/pkg/diffutils/trunk/work/solaris10-i386/build-isa-pentium_pro/diffutils-3.3.57-a37c/tests'
>> gmake[2]: Entering directory 
>> '/home/dam/mgar/pkg/diffutils/trunk/work/solaris10-i386/build-isa-pentium_pro/diffutils-3.3.57-a37c/tests'
>> diff: missing operand after `diff'
>> diff: Try `diff --help' for more information.
>> diff3: missing operand after `diff3'
>> diff3: Try `diff3 --help' for more information.
>> sdiff: missing operand after `sdiff'
>> sdiff: Try `sdiff --help' for more information.
>> /bin/sh: built_programs^Jdiff^Jdiff3^Jsdiff: is not an identifier

I suspect that you are using an old version of GNU make.
What if you use Solaris' make?
This patch should work around it, but then again, this patch should
not be required, and I doubt I will have to resort to that approach.

> On Solaris 9 I still get this error:
>
>> unstable9s% gmake V=1
>> Making all in lib
>> gmake[1]: Entering directory 
>> `/home/dam/mgar/pkg/diffutils/trunk/work/solaris9-sparc/build-isa-sparcv8/diffutils-3.3.57-a37c/lib'
>> gmake  all-am
>> gmake[2]: Entering directory 
>> `/home/dam/mgar/pkg/diffutils/trunk/work/solaris9-sparc/build-isa-sparcv8/diffutils-3.3.57-a37c/lib'
>> depbase=`echo error.o | sed 's|[^/]*$|.deps/&|;s|\.[^.]*$||'` && \
>> /opt/csw/bin/gcc-4.6 -std=gnu99  -I.   -I/opt/csw/include -W -Wabi -Waddress 
>> -Wall -Wattributes -Wbad-function-cast -Wbuiltin-macro-redefined 
>> -Wcast-align -Wchar-subscripts -Wclobbered -Wcomment -Wcomments 
>> -Wcoverage-mismatch -Wcpp -Wdeprecated -Wdeprecated-declarations 
>> -Wdisabled-optimization -Wdiv-by-zero -Wdouble-promotion -Wempty-body 
>> -Wendif-labels -Wenum-compare -Wextra -Wformat-contains-nul 
>> -Wformat-security -Wformat-y2k -Wformat-zero-length -Wignored-qualifiers 
>> -Wimplicit -Wimplicit-function-declaration -Wimplicit-int -Winit-self 
>> -Wint-to-pointer-cast -Winvalid-pch -Wjump-misses-init -Wmain 
>> -Wmissing-braces -Wmissing-declarations -Wmissing-field-initializers 
>> -Wmissing-include-dirs -Wmissing-parameter-type -Wmultichar -Wnonnull 
>> -Wold-style-declaration -Woverflow -Woverlength-strings -Woverride-init 
>> -Wpacked -Wpacked-bitfield-compat -Wparentheses -Wpointer-arith 
>> -Wpointer-sign -Wpointer-to-int-cast -Wpragmas -Wreturn-type 
>> -Wsequence-point -Wshadow -Wstrict-aliasing -Wstrict-prototypes 
>> -Wsuggest-attribute=const -Wsuggest-attribute=noreturn -Wswitch -Wsync-nand 
>> -Wtrampolines -Wtrigraphs -Wtype-limits -Wuninitialized -Wunknown-pragmas 
>> -Wunused -Wunused-but-set-parameter -Wunused-but-set-variable 
>> -Wunused-function -Wunused-label -Wunused-parameter -Wunused-result 
>> -Wunused-value -Wunused-variable -Wvariadic-macros -Wvolatile-register-var 
>> -Wwrite-strings -Wnormalized=nfc -Wno-missing-field-initializers 
>> -Wno-missing-field-initializers -Wno-sign-compare -Wno-pointer-sign 
>> -Wno-unused-parameter -Wno-format-nonliteral -Wno-logical-op 
>> -fdiagnostics-show-option -funit-at-a-time -Werror -O2 -pipe 
>> -fno-omit-frame-pointer -mcpu=v8 -MT error.o -MD -MP -MF $depbase.Tpo -c -o 
>> error.o  error.c && \
>> mv -f $depbase.Tpo $depbase.Po
>> error.c:112:1: error: function declaration isn't a prototype 
>> [-Werror=strict-prototypes]
>> cc1: all warnings being treated as errors

That build is using a very old compiler: gcc-4.6. I'd upgrade, for
half a decade of improvements in code-generation and warnings.
With any but the most up-to-date compilers, you should avoid turning
on all of those warnings (and especially -Werror), so you can probably
work around this one simply by running configure without
--enable-gcc-warnings.