[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug-diffutils] bug#51228: bug#51228: Incorrect timezone in unified diff

From: Paul Eggert
Subject: [bug-diffutils] bug#51228: bug#51228: Incorrect timezone in unified diff on Solaris?
Date: Fri, 15 Oct 2021 19:05:36 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0

On 10/15/21 6:55 AM, Vladimir Marek wrote:

I am not entirely sure where is nstrftime.c coming from, so I'm
reporting the issue here.

Thanks for reporting it. Although nstrftime.c comes from Gnulib, this is a diffutils bug: the 0 diffutils passes to nstrftime stands for Universal Time (UT), whereas local time is wanted. This bug is not triggered on GNU/Linux or the BSDs, which have tm_gmtoff in their struct tm.

I installed the attached patch into diffutils. Please give it a try, as the patch you sent mishandles the case when today's UT offset differs from the UT offset in effect when the file was last modified (e.g., due to a daylight-saving change).

Attachment: 0001-diff-fix-timezone-bug-on-Solaris.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]