Re: [Bug-ed] [PATCH] minix port

[Antonio Diaz Diaz]

Hello Thomas,

Thomas Cort wrote:
> Attached is a patch to port GNU ed to Minix 3. It allows GNU ed to be
> compiled on Minix with the ANSI-C compiler from the Amsterdam Compiler
> Kit (the default C compiler for Minix3). The resulting binary works
> fine and passes the test suite.

Thanks for the patch. Just a couple comments.


> +       * Converted C99 style comments '// foo' to ANSI style comments /* foo */
> +       * carg_parser.c: fix constant declaration near line 156.

I'll aply those directly to the Arg_parser source. 
http://www.nongnu.org/arg-parser/arg_parser.html


> +       * regex.c: make se_max a constant.

Does an enum, like in the example below, work? I would prefer to keep ed 
free of macros.

  enum { se_max = 30 }; /* max subexpressions in a regular expression */
  regmatch_t rm[se_max];


Regards,
Antonio.