[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: locate.c (visit_exists): Use printname, not testname.

From: Bas van Gompel
Subject: Re: locate.c (visit_exists): Use printname, not testname.
Date: Tue, 4 Jan 2005 03:43:13 +0100 (MET)
User-agent: slrn/ (Win32) Hamster/ Korrnews/4.2

Op Mon, 3 Jan 2005 10:17:48 +0000 schreef James Youngman
in <address@hidden>:
:  On Mon, Jan 03, 2005 at 02:44:35AM +0100, Bas van Gompel wrote:
: > ``procdata->raw_string'' and ``procdata->munged_string''?
:  Good idea.

Are you doing this?

: > BTW: Why don't you allow ``locate -b string''?
:  No reason - I've just added it as a synonym for --basename which is
:  what I assume you had in mind.

I just noticed same goes for ``-w''.
Also: In the ``SYNOPSIS'' in locate.1, some ``-''s are not escaped.
And: In locate.c, the usage is incomplete. (-bwSc0ms, --null, --count,


: > BTW4: Although I like the source comment (about adding visit_exists
: > late), I don;t think I deserve the credit for this. The info/man text
: > about --existing seem (to me) to express an intent to do it this way.

:  Yes, it's a bugfix.

The comment states it was my idea. It was not, IMNSHO.

[GNU copyright-assignments/disclaimers]

:  OK.  What are the modifications you have in mind?

* Add a ``--non-existing'' (``-E'') option.
* Add a ``--print'' (``-p'') option. (to cancel side-effects of -c/-S)
* Move limit-checking and counting into ``visitor''s.
* Read each database only once. (This is not a small change, I'd say.)
* More, most of which depend on the above...

I don't just have these in mind, I have a local version /with/ them

I guess I'll have to break each out so they can get commited.
(I should have used a local version control system.)

:  Would you like to assign all future contributions to findutils also?
:  That will make it simpler to continue to contribute later (because you
:  would not have to redo the paperwork).  If you don't want to do that,
:  it's OK, the assignment papers for just the set of changes you're
:  contributing now would work.

If the wording of your copyright-assignments is anything like Red Hat's,
I'll probably prefer to disclaim, or talk to your legal dept. Could
you please just send me (in personal mail [PM], <ja dash y dot buzz
at bavag dot tmfweb dot nl>) both (template) texts, so I can make up my


  ) |  | ---/ ---/  Yes, this | This message consists of true | I do not
--  |  |   /    /   really is |   and false bits entirely.    | mail for
  ) |  |  /    /    a 72 by 4 +-------------------------------+ any1 but
--  \--| /--- /---  .sigfile. |   |perl -pe "s.u(z)\1.as."    | me. 4^re

reply via email to

[Prev in Thread] Current Thread [Next in Thread]