[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-gnulib] Re: [patch #3741] Added support for Interix within moun

From: Paul Eggert
Subject: Re: [bug-gnulib] Re: [patch #3741] Added support for Interix within mountlist.c
Date: Tue, 15 Feb 2005 09:39:02 -0800
User-agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.4 (gnu/linux)

Jim Meyering <address@hidden> writes:

> +     /* In the unlikely event that opendir and each readdir
> +        succeed, but all statvfs calls fail, ensure that we
> +        fail with a valid errno value.  */

If I'm understanding the code correctly, the comment should read "a
statvfs call fails", not "all statvfs calls fail".

> +     char file_name[9 + NAME_MAX]; /* 8 for /dev/fs/ + 1 for NUL */

A minor point.  The above can be replaced by something like this:

    static char const DEV_FS[] = "/dev/fs/";
    char file_name[sizeof DEV_FS + NAME_MAX];

and then you can replace later occurrences of "/dev/fs/" with DEV_FS.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]