Re: [patch] Recent findutils test suite failures

[James Youngman]

On Wed, Nov 23, 2005 at 11:45:48AM +0000, Tim Waugh wrote:
> With this patch in addition to yours (and removing the .xo files), I
> no longer see any failures.
> 
> diff -u findutils-4.2.26/lib/buildcmd.c findutils-4.2.26/lib/buildcmd.c
> --- findutils-4.2.26/lib/buildcmd.c   2005-11-23 09:47:48.000000000 +0000
> +++ findutils-4.2.26/lib/buildcmd.c   2005-11-23 09:47:48.000000000 +0000
> @@ -195,7 +195,7 @@
>    if (!initial_args && ctl->args_per_exec &&
>        ( (state->cmd_argc - ctl->initial_argc) == ctl->args_per_exec))
>      return 1;
> -  else if (state->cmd_argc == ARG_MAX / sizeof (void *) - 1)
> +  else if (state->cmd_argc == ARG_MAX / sizeof (void *) - 2)


What happens if the command you are executing via xargs is "echo foo
bar" rather than just "echo"?  Does the required 2 turn into a
required 4? (I assume not, but just to be sure...)

James.