[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[patch #5280] environment size is not subtracted in one case
From: |
Miloslav Trmac |
Subject: |
[patch #5280] environment size is not subtracted in one case |
Date: |
Mon, 7 Aug 2006 02:05:15 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; cs-CZ; rv:1.8.0.4) Gecko/20060614 Fedora/1.5.0.4-1.2.fc5 Firefox/1.5.0.4 pango-text |
URL:
<http://savannah.gnu.org/patch/?func=detailitem&item_id=5280>
Summary: environment size is not subtracted in one case
Project: findutils
Submitted by: mitr
Submitted on: Monday 08/07/2006 at 02:05
Category: xargs bugfix
Priority: 5 - Normal
Status: None
Privacy: Public
Assigned to: None
Originator Name:
Originator Email:
Open/Closed: Open
Release: None
Fixed Release: None
_______________________________________________________
Details:
First, findutils-4.2.28 bc_init_controlinfo() contains the line
ctl->posix_arg_size_max - size_of_environment;
... which does nothing at all.
Nevertheless environment size is correctly subtracted in the first
case in bc_use_sensible_arg_max () - so it works correctly on Linux
- but not in the other cases.
The attached patch:
- removes the abovementioned line without an assignment
- modifies bc_use_sensible_arg_max() to subtract env_size in the
third case.
I have tested the result on i386 Linux: it passes the test suite
and (find -exec echo {} +) with a large environment seems to work.
I don't have any other platform readily available.
_______________________________________________________
File Attachments:
-------------------------------------------------------
Date: Monday 08/07/2006 at 02:05 Name: p Size: 1.01KB By: mitr
Subtract environment size from ctl->arg_max
<http://savannah.gnu.org/patch/download.php?file_id=10476>
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/patch/?func=detailitem&item_id=5280>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
- [patch #5280] environment size is not subtracted in one case,
Miloslav Trmac <=