[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Draft for xattr support

From: leslie . polzer
Subject: Re: [PATCH] Draft for xattr support
Date: Wed, 4 Apr 2007 22:23:04 +0200
User-agent: mutt-ng/devel-r804 (Linux)

On Tue, Apr 03, 2007 at 11:33:54PM +0100, James Youngman wrote:

> When adding an item to struct predicate, please use a comment to
> indicate which predicates it supports.


> <attr/attributes.h> maynot be available on all platforms, so configure
> should check for it.

Yeah, that's a TODO for me.

> fnmatch_sanitycheck(); -- this only needs to be called once, ever.

Alright, but currently each predicate supporting globbing seems to be
responsible of calling it.

Maybe think of a way of centralizing that decision?

> +    error (0, 0, "missing attribute name (format: ATTR=VALUE)")     ;
> +    state.exit_status = 1 return (false)                            ;
> Works, but this is easier & better: error (1, 0, "missing attribute
> name (format: ATTR=VALUE)");

Thanks a bunch!

> I see that you are expecting -xattr NAME=FOO and have plans for glob
> support. This sounds good so far. When designing this though, please
> think about how to support this sort of functionality on a variety of
> systems (that is, not just on one filesystem or OS).

Subject treated in other message.

> Oh, and one piece of bad news: you have a potential name clash. Some
> systems may appear to support xattr_get() just because we accidentally
> linked in the curses library. Not sure how to protect ourselves
> against that one.

Well, let's avoid that name then.

> Thanks for your work so far!

Why certainly, hacking find's well-structured code is a breeze
compared to other projects! :)

Are you responsible for this, or did you find it when you got to


NEW homepage: https://viridian.dnsalias.net/~sky/homepage/
gpg --keyserver pgp.mit.edu --recv-keys DD4EBF83

Attachment: pgplcawjAq4Oq.pgp
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]