Re: fd_is_cloexec () does not work on Fedora buildhosts

[James Youngman]

2010/4/3 Kamil Dudka <address@hidden>:
> Hello,
>
> thanks for the new release of findutils in the first place!
>
> While I was trying to build packages for Fedora, I ran into huge test-suite
> failure.  For merely all tests the assertion within complain_about_leaky_fds
> () failed on the descriptor 3 or 4.
>
> Poking around, I discovered the function fd_is_cloexec () does not work
> there.  As it seems to be kernel specific, I haven't been able to reproduce
> it locally.

I suspect what's happening is that the library on your build hosts
defined O_CLOEXEC, but your kernel lacks support for it.   fcntl(fd,
F_GETFL) may just return the original flags we passed, meaning that
it's not a guarantee that the O_CLOEXEC actually had an effect.

Please test the attached alternative patch and let me know if it
solves your problem.

Thanks,
James.

0001-Fix-open_cloexec-on-hosts-which-ignore-O_CLOEXEC-i.e.patch
Description: Text Data