[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] find: use FTS_VERBATIM

From: James Youngman
Subject: Re: [PATCH] find: use FTS_VERBATIM
Date: Sat, 15 Dec 2012 14:33:09 +0000

On Sun, Nov 18, 2012 at 2:06 AM, Dmitry V. Levin <address@hidden> wrote:
> The recent change v0.0-7611-g3a9002d in gnulib that made fts_open strip
> trailing slashes from input path names had a negative impact on
> findutils that relies on the old fts_open behavior to implement POSIX
> requirement that each path operand of the find utility shall be
> evaluated unaltered as it was provided, including all trailing slash
> characters.
> A new bit flag FTS_VERBATIM was added later as the option to disable
> that stripping when it is not desirable.
> * gnulib: update to latest, to get FTS_VERBATIM support.
> * find/ftsfind.c (ftsoptions): Set the FTS_VERBATIM bit.

Thanks for this contribution.   Since you have already completed a
copyright assignment for Findutils, I was able to simply apply your
patch directly.

I also needed to make an additional change to ensure that the
regression test suite still passed after the gnulib update, since the
gnulib update also contained a change to the semantics of the awk,
gnu-awk and posix-awk regular expression types.  In order to avoid
there being an intermediate commit in which the regression tests did
not pass, I aggregated your change with the regexprops.texi fix into a
single commit, and I've attached the resulting patch to this email.
The patch has already been applied to the master (i.e. 4.5.x) branch.

Thanks again for your contribution,

Attachment: 0001-find-use-FTS_VERBATIM-and-update-gnulib.patch
Description: Binary data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]