[bug #42937] xargs --show-limits environment size subtracted twice possibly

[anonymous]

URL:
  <http://savannah.gnu.org/bugs/?42937>

                 Summary: xargs --show-limits environment size subtracted
twice possibly
                 Project: findutils
            Submitted by: None
            Submitted on: Thu 07 Aug 2014 06:29:20 PM UTC
                Category: xargs
                Severity: 3 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
         Originator Name: Donald Zoch
        Originator Email: address@hidden
             Open/Closed: Open
         Discussion Lock: Any
                 Release: 4.4.2
           Fixed Release: None

    _______________________________________________________

Details:

Hi

We have some code that parses the output of

xargs -show-limits

specifically the

"Maximum length of command we could actually use"  line

We noticed when updating from findutils 4.2.30 to 4.4.2 that it appeared the 
number was different and it appeared that the
environment size was being subtracted twice.

I notice in findutils 4.2.30 that line 446 in buildcmd.c doesn't actually 
modify ctl->posix_arg_size_max

ctl->posix_arg_size_max - size_of_environment;

This was changed/corrected  to

ctl->posix_arg_size_max -= size_of_environment;

in findutils 4.4.2, buildcmd.c line 479

So in xargs.c, should line 699 be changed to not subtract the environment
again?

699,700c699
<             (unsigned long)(bc_ctl.posix_arg_size_max -
<                             bc_size_of_environment()));
---
>             (unsigned long)bc_ctl.posix_arg_size_max);


Thank you

Donald Zoch




    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?42937>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/