[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Several changes made to fts.c in Gnulib

From: Kamil Dudka
Subject: Re: Several changes made to fts.c in Gnulib
Date: Wed, 26 Jul 2017 09:56:06 +0200
User-agent: KMail/4.14.10 (Linux/4.9.34-gentoo; KDE/4.14.32; x86_64; ; )

On Tuesday, July 25, 2017 20:26:43 Paul Eggert wrote:
> Kamil Dudka wrote:
> > While I respect your opinion about removing this debugging facility
> > upstream, the -noleaf option stays implemented in Fedora.
> That shouldn't be a problem. As I mentioned, findutils can still support
> -noleaf even when using unmodified Gnulib.

I fail to see why modifying gnulib/fts would be a problem.  Yesterday you 
pushed 5 commits with the following diffstat:

 ChangeLog  |  35 +++++++
 lib/fts.c  | 323 
 lib/fts_.h |   6 +-
 3 files changed, 202 insertions(+), 162 deletions(-)

You even admitted that they could have introduced new bugs.  Now you are 
refusing to push a tiny commit that would significantly help to debug them
in environments where only binaries are available.

> Just have -noleaf turn off FTS_CWDFD.

That would have unexpected side effects that would complicate the debugging.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]